Highlights
Denial of Service: 4 prior fixes. Scrutinize any change in this area.
lianad/src/commands/mod.rs: most-fixed (2 issues). Treat as high-risk during review.
0 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: The coin selection mechanism previously relied on weak indicators to identify self-owned change, potentially allowing unconfirmed, untrusted external deposits to be spent under the assumption they were safe, internal change coins. Developers must use 'is_from_self' rather than relying on 'is_change' flags.
Denial of Service: Unbounded resource usage or excessive key generation can occur if client calls request large key-generation index updates. Restricting index increments is necessary to prevent exhaustion of system memory or CPU during gap index updates.
Denial of Service: Uncontrolled panics can crash the daemon when concurrent block rescans are triggered. Operations expecting a linear, non-overlapping rescan flow should propagate descriptive errors up the stack instead of invoking 'assert!' or 'panic!'.