Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

tootallnate/proxy-agents
main @ b7e5f7c
6
Fixes
0
CVEs
CRITICAL
Peak severity
25.0%
Coverage
Highlights
Broken Cryptography: 2 prior fixes. Scrutinize any change in this area.
pac-proxy-agent: most-fixed (2 issues). Treat as high-risk during review.
3 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Sandbox Escape: Execution of untrusted PAC script files via vulnerable VM sandboxes like vm2 can lead to complete host compromise and remote code execution. Migrating to a WebAssembly-based QuickJS engine mitigates this, but any fallback path or unsafe evaluation context remains a critical target.
Improper Certificate Validation: Direct TLS connections failing to configure the SNI servername skip critical hostname verification checks, enabling silent man-in-the-middle (MITM) attacks on proxied traffic.
Broken Cryptography: Incorrectly handling IP addresses in TLS options—either by omitting the SNI for raw IPs or incorrectly clearing the servername when net.isIP() matches—prevents valid certificate validation or breaks the TLS handshake.