Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

timvisee/ffsend
master @ 85aae2f
4
Fixes
0
CVEs
HIGH
Peak severity
Highlights
Path Traversal: 2 prior fixes. Scrutinize any change in this area.
src/action/upload.rs: most-fixed (3 issues). Treat as high-risk during review.
1 high-severity fix in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Path Traversal: Archiving multiple files allows directory traversal if paths are not canonicalized and checked against a strict base-directory prefix before being appended. Attackers could potentially read sensitive files outside the intended directory.
Cryptographic Issues: Misusing AEAD encryption for generating metadata signatures can allow signature bypass or integrity compromise. The project had to transition to proper HMAC-SHA256 signature verification to enforce metadata integrity.
Information Disclosure: Automatically shortening URLs via third-party services leaks secret download links to external systems without explicit user consent.