Security context

Highlights

Denial of Service: 11 prior fixes. Scrutinize any change in this area.

src/command.cpp: most-fixed (5 issues). Treat as high-risk during review.

5 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

Integer Overflow: Multiplication operations involving matrix dimensions and element sizes can overflow 32-bit types during initialization, reshaping, or row addressing, leading to out-of-bounds heap memory access via memcpy. Offsetting or sizing calculations must explicitly cast operands to size_t before multiplication.

Out-of-bounds Write: Parsing model weights or text parameter dictionaries with out-of-bound parameter indices can bypass array bounds and overwrite critical internal structures inside the network configuration. Models must be validated against a strict parameter ID index range.

Heap-based Buffer Overflow: Layer dimension transformations and packing configurations evaluate memory requirements using implicit integer types. Failing to promote multiplication operands to size_t results in small allocation sizes followed by massive heap buffer corruption during packing runs.