Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

streamlabs/desktop
master @ c88761e
23
Fixes
50
CVEs
CRITICAL
Peak severity
45.0%
Coverage
Highlights
Auth Bypass: 4 prior fixes. Scrutinize any change in this area.
app/services/user/auth-module.ts: most-fixed (3 issues). Treat as high-risk during review.
12 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Credential Leakage: The application historically embedded static AWS credentials in its cache-uploader service, exposing critical S3 bucket access to anyone inspecting the binary. This was resolved by shifting to Cognito Identity Pools and presigned S3 URLs.
Code Execution: Downloaded installer packages were executed using child_process.exec without proper signature verification, leaving the application open to arbitrary binary execution if a download path was hijacked. The fix introduced strict Authenticode signature and subject checking.
Auth Bypass: Flaws in the PKCE authorization flow allowed for auth bypass due to incomplete enforcement of validation checks. Secure validation requires both code_verifier and code to be validated alongside one another, and authorization codes must be propagated properly on internal login paths.