Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

shopify/sarama
main @ 6aaff07
4
Fixes
0
CVEs
HIGH
Peak severity
Highlights
Improper Certificate Validation: 2 prior fixes. Scrutinize any change in this area.
broker.go: most-fixed (3 issues). Treat as high-risk during review.
1 high-severity fix in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Improper Certificate Validation: Misconfiguration or sharing of `tls.Config` across broker connections can lead to race conditions or default states where host verification (SNI) is bypassed, exposing connections to Man-in-the-Middle (MitM) attacks.
Command Injection: Direct string expansion of runner inputs in workflow files allows arbitrary command injection. Inputs like `kafka-version` must always be bound to environment variables.
Weak TLS Configuration: Default TLS settings failing to enforce a secure minimum version (TLS 1.2) allow protocol downgrade attacks, leaving encrypted transport vulnerable to legacy cryptographic exploits.