Highlights
Auth Bypass: 7 prior fixes. Scrutinize any change in this area.
src/onelogin/saml2/idp_metadata_parser.py: most-fixed (3 issues). Treat as high-risk during review.
8 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: Inconsistent or faulty parsing of the 'WantAuthnRequestsSigned' metadata option from XML nodes could allow attackers to bypass signature requirements for AuthnRequests, failing to enforce transport-level trust.
Auth Bypass: Flawed logic in cryptographic assertions—including backwards set differences for requested authentication contexts and accepting deprecated SHA-1 signatures—allows unauthenticated attackers to forge or inject arbitrary SAML assertions.
XML External Entity (XXE): Standard XML parsers in Python are vulnerable to XXE and external entity resolution. The project required explicit custom configuration of the lxml parser to prevent arbitrary file disclosure and server-side request forgery during SAML assertion parsing.