Highlights
Cryptographic Issues: 2 prior fixes. Scrutinize any change in this area.
src/modular/monty_params.rs: most-fixed (2 issues). Treat as high-risk during review.
2 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Cryptographic Issues: Incomplete constant-time equivalence comparison of Montgomery parameters omitted internal structural fields, which could permit differing moduli to be evaluated as equivalent during cryptographic steps. Additionally, modulo-one initialization risks producing non-canonical residues rather than zero.
Integer Overflow: Limb-count calculation using bit counts close to maximum limits can wrap around due to narrow integer addition, resulting in incorrect allocation calculations or out-of-bounds assumptions in release builds.
Denial of Service: Constant-time division can panic when converting unsigned remainders to signed representations if the value overflows the signed capacity, leading to denial of service in processing untrusted inputs.