Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

requests/requests-ntlm
master @ 717339f
2
Fixes
0
CVEs
HIGH
Peak severity
Highlights
Auth Bypass: 2 prior fixes. Scrutinize any change in this area.
requests_ntlm/requests_ntlm.py: most-fixed (2 issues). Treat as high-risk during review.
1 high-severity fix in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Auth Bypass: The client generated Channel Binding Tokens using certificates retrieved from an entirely separate, newly established socket connection rather than reusing the active, authenticated connection's TLS context. This decoupling allowed potential authentication bypasses or credential relay attacks if the secondary connection did not match the original session.
Auth Bypass: Rigid instance checking against SSLSocket during CBT certificate retrieval prevented proper extraction of peer certificates when using alternative socket implementations (like wrapped or customized adapters). Relaxing this to check for the 'getpeercert' attribute ensures consistent CBT generation across diverse transport layers.