Highlights
HTTP Request Smuggling: 10 prior fixes. Scrutinize any change in this area.
src/waitress/parser.py: most-fixed (7 issues). Treat as high-risk during review.
11 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
HTTP Request Smuggling: Inconsistent or weak validation of crucial HTTP headers (such as Content-Length, Host, and Transfer-Encoding) has repeatedly allowed request smuggling. Ensuring duplicate headers are rejected and enforcing strict validation patterns is vital.
HTTP Request Smuggling: Weaknesses in parsing chunked encoding, including trailing whitespace allowances and unvalidated chunk extensions or non-hexadecimal characters, create smuggling opportunities when chained with front-end proxies.
Denial of Service: Race conditions involving concurrent socket closures by worker threads and state initialization checks can trigger infinite loops or unhandled exceptions inside the main select loop, leading to server exhaustion.