Highlights
Command Injection: 2 prior fixes. Scrutinize any change in this area.
src/solidlsp/language_servers/eclipse_jdtls.py: most-fixed (2 issues). Treat as high-risk during review.
2 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Command Injection: Processes launched with shell-joined string commands instead of structured argument lists allow remote code execution if arguments contain shell metacharacters.
Command Injection: Concatenating user or workspace paths directly into command strings for process launchers allows command execution under the privileges of the LSP server.
Denial of Service: Synchronous event waiting without reasonable timeouts allows deadlocks and thread starvation, making the server unresponsive under specific conditions.