Highlights
Auth Bypass: 94 prior fixes. Scrutinize any change in this area.
apps/src/lib/node/ledger/shell/vote_extensions/validator_set_update.rs: most-fixed (7 issues). Treat as high-risk during review.
192 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: MASP validity predicates historically suffered from validation gaps, such as incorrect state transitions, unchecked user-supplied anchors, and lack of signature verification for debited balances. This allowed potential unauthorized balance manipulation or state modifications.
Denial of Service: Arithmetic and conversion logic within shielded token reward distribution failed to check for mathematical overflows, creating node-crashing panics during execution. Enforcing bound checks and checked arithmetic is vital.
Auth Bypass: Multi-token and trans-token validity predicates bypassed crucial signature checks on non-internal or destination addresses, permitting unauthorized token debits. VPs must verify all participating transaction addresses.