Highlights
Auth Bypass: 15 prior fixes. Scrutinize any change in this area.
server/server.js: most-fixed (22 issues). Treat as high-risk during review.
26 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Auth Bypass: The platform suffered critical setup and 2FA bypass vulnerabilities. Setup logic allowed unauthorized administrator generation due to broken user-count checks, and multiple 2FA bypasses existed due to improper session delay until after TOTP validation and token-replay weaknesses.
Command Injection: Executing external binaries like sipsak or systemctl using unparameterized shell-exec commands enabled critical remote code execution vectors. Senders could inject shell metacharacters through input parameters.
SQL Injection: Dynamic query execution during database initialization and engine setup allowed unescaped parameters, leading to potential arbitrary SQL injection vectors before migration to parameterized engines like Knex.