Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

lizardbyte/sunshine
master @ 2438a9b
24
Fixes
11
CVEs
CRITICAL
Peak severity
44.4%
Coverage
Highlights
Auth Bypass: 7 prior fixes. Scrutinize any change in this area.
src/nvhttp.cpp: most-fixed (9 issues). Treat as high-risk during review.
12 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Auth Bypass: The client pairing protocol has historically suffered from broken state progression, allowing unauthenticated attackers to bypass authentication by initiating out-of-order handshakes or using unvalidated legacy endpoints. Keeping the state machine strictly synchronized and immediately terminating sessions on verification errors is paramount.
CSRF: The web configuration interface lacks default CSRF protection, enabling remote attackers to execute arbitrary state-changing operations (such as saving applications, passwords, or changing system configurations) via client browsers. Mitigation requires strict origin and JSON Content-Type validation.
Path Traversal: Static file servers (specifically endpoints routing under 'node_modules') allowed unauthenticated remote users to read arbitrary files from the host filesystem due to missing path canonicalization and directory containment checks.