Security context

Highlights

Command Injection: 1 prior fix. Scrutinize any change in this area.

src/logging.cc: most-fixed (2 issues). Treat as high-risk during review.

2 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

Command Injection: The logging component sends notification emails via popen-based mailers, which are susceptible to command and argument injection if destination addresses are not rigorously validated. Future modifications to email-sending utilities must preserve strict alphanumeric-start regex validation.

Memory Safety: Stateful pointer arithmetic in the C++ demangler's ParseIdentifier can result in stack buffer overflows if remaining string bounds are not explicitly checked. Any future parsing additions must strictly enforce current-offset limits.

Memory Corruption: Use-after-free (UAF) vulnerabilities occur when pointers are bound to temporary std::string objects whose lifetime ends before the pointer is consumed, particularly within internal helper routines like SendEmailInternal.