Highlights
Information Disclosure: 1 prior fix. Scrutinize any change in this area.
include/spdlog/sinks/syslog_sink.h: most-fixed (1 issue). Treat as high-risk during review.
1 high-severity fix in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Integer Overflow: Large log payload sizes can cause integer overflows when interacting with systemd journal APIs like sd_journal_send, potentially leading to heap corruption or crash scenarios. Clamping and strict boundary validation of the payload size are required.
Information Disclosure: Logging non-null-terminated buffers directly via format strings to the syslog API can cause out-of-bounds reads and leak process memory. Using precision-limited format specifiers like %.*s based on validated payload lengths is necessary to prevent leaks.
Denial of Service: The scoped_padder function is vulnerable to resource consumption attacks via manipulation of padding fields, which could allow local attackers to degrade application performance or trigger a denial of service.