Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

errbotio/errbot
master @ 646019a
11
Fixes
0
CVEs
HIGH
Peak severity
28.6%
Coverage
Highlights
Auth Bypass: 8 prior fixes. Scrutinize any change in this area.
errbot/core_plugins/acls.py: most-fixed (4 issues). Treat as high-risk during review.
8 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Auth Bypass: Flaws in the core ACL evaluation logic, such as treating non-string identifiers improperly, performing loose character-by-character glob matching, or completely discarding default fallback rules when specific commands are configured, present a critical risk of complete command authorization bypass.
Auth Bypass: The IRC adapter historically validated commands using easily spoofed nicknames instead of the full hostmask, allowing unauthorized users to impersonate administrators. Failure to consistently enforce robust host-level patterns when evaluating permissions is a major risk on IRC networks.
Arbitrary Code Execution: Unsafe handling of standard input and backup restoration using raw python `eval` and `exec` commands allowed local or context-based arbitrary code execution before being replaced with safer abstract syntax tree parsing.