Security context

What an agent needs to avoid regressing past fixes and find the next vuln in this repo.

dromara/maxkey

              main @ 4bc7999
            

Fixes

CVEs

CRITICAL

Peak severity

45.0%

Coverage

Highlights

Auth Bypass: 35 prior fixes. Scrutinize any change in this area.

maxkey-core: most-fixed (4 issues). Treat as high-risk during review.

41 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

The bug types that recur here, drawn from past fixes, not open vulnerabilities.

Auth Bypass: A critical flaw validated user credentials against the username instead of the password, allowing absolute authentication bypass. Developers must ensure standard credential validation steps are correctly mapped to cryptographic password encoders.

Authentication Bypass: The email password-reset OTP token validator was hardcoded to return true, allowing arbitrary account takeover via the password reset flow. Avoid stubbing or shortcutting authorization validators in production-bound pathways.

Auth Bypass: Logical inversions in JWT expiration validation allowed expired tokens to be accepted while rejecting valid unexpired ones. Proper date/time boundaries must be rigorously tested.