Highlights
Denial of Service: 2 prior fixes. Scrutinize any change in this area.
daphne/http_protocol.py: most-fixed (2 issues). Treat as high-risk during review.
3 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
HTTP Header Injection: Inconsistent parsing of headers containing control characters between Twisted and Autobahn during WebSocket handshakes allows attackers to inject headers, resulting in a smuggling or injection vector. Developers must strictly validate raw headers before passing them down.
Denial of Service: Uncapped WebSocket frame and message payload sizes can lead to rapid, unauthenticated memory exhaustion. Enforcing explicit limits during the initialization of the WebSocket factory is necessary to mitigate DoS.
HTTP Request Smuggling: Failure to validate HTTP header names against RFC specifications can lead to parsing mismatches and request smuggling. Using strict regular expression checks on header keys is essential.