Highlights
Command Injection: 31 prior fixes. Scrutinize any change in this area.
scripts/lib/security.sh: most-fixed (17 issues). Treat as high-risk during review.
70 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Command Injection: Manifest-to-bash code generation pipeline routinely interpolated unescaped or partially escaped strings into output scripts, permitting arbitrary shell execution. Remediation requires strict escaping of bash metacharacters and single-quoting inputs.
Privilege Escalation: Wrapper scripts executed target binaries using user-controlled parameters or fallback environment variables (such as ACFS_BIN_DIR), which allowed local users to hijack privileged execution environments. These pathways were hardened by dropping environment fallbacks and validating execution paths against stored canonical state files.
Signature Verification Bypass: Checksum loading and integrity verification procedures allowed validation bypasses due to incomplete metadata parsing, non-anchored regex validation, and state-clearing on execution failures. Corrective actions introduced anchored patterns, strict YAML block formatting, and transactional state updates.