Security context

Highlights

Auth Bypass: 28 prior fixes. Scrutinize any change in this area.

crypto/CryptoAuth.c: most-fixed (32 issues). Treat as high-risk during review.

56 high-severity fixes in this history; regressions here are high-impact.

Recurring patterns

Auth Bypass: A critical logical inversion in the return value validation of message decryption allowed unauthenticated handshakes to succeed and sessions to establish without valid cryptographic verification. Sibling commits also suffered from fall-through logic and unhandled handshake decryption failures.

Insufficient Entropy: The custom entropy collection layer had a critical vulnerability where it limited reads from '/dev/urandom' to the size of the pointer holding the buffer (4 or 8 bytes) rather than the size of the buffer itself (64 bytes), resulting in severely weakened cryptographic PRNG seeding. Sibling bugs accepted zeroed buffers as valid entropy due to incorrect memset sizing.

Privilege Escalation: Privilege reduction attempts failed silently or partially. In one instance, the application failed to handle errors returned by setuid/setgid, allowing execution to continue silently as root. In another, user privileges were dropped without dropping group privileges (GID), leaving the application vulnerable to group-based privilege escalation.