Highlights
Command Injection: 1 prior fix. Scrutinize any change in this area.
crates/cli/src/decompress.rs: most-fixed (1 issue). Treat as high-risk during review.
2 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Command Injection: On Windows, executing relative binaries via -z/--search-zip or --pre flags allowed local command execution if an attacker controlled the current working directory. Future preprocessor or decompression additions must enforce strict path canonicalization and prefix verification.
Memory Safety: Bypassing UTF-8 verification checks using unsafe Rust interfaces when configuring PCRE2 can lead to undefined behavior or memory corruption. The application should rely on native engine options (like match-invalid-utf) rather than bypassing safe boundaries.
Denial of Service: Spawning command-executing readers can result in leaked child processes and resource exhaustion if explicit close and drop handlers are not rigorously implemented. All subprocess-wrapping reader components must guarantee clean-up on drop.