Highlights
Path Traversal: 2 prior fixes. Scrutinize any change in this area.
llmfit-core/src/providers.rs: most-fixed (4 issues). Treat as high-risk during review.
2 high-severity fixes in this history; regressions here are high-impact.
Recurring patterns
The bug types that recur here, drawn from past fixes, not open vulnerabilities.
Path Traversal: Path traversal during the retrieval and writing of GGUF model files can allow attackers to overwrite arbitrary files on the local filesystem. This occurred across multiple locations handling model storage and downloads, requiring rigorous filename validation.
Argument Injection: Command execution parameters for Hugging Face and Docker CLI processes were vulnerable to argument injection, which can lead to local command execution if inputs are not safely isolated using '--' option separators.
Insecure Temporary File: The use of predictable temporary file locations for downloaded model parts left the system vulnerable to symlink-chasing and race-condition attacks, necessitating exclusive file creation options.